Refactor latest DagRun load options for consistency#67911
Open
henry3260 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
cc @jason810496 |
eladkal
added
the
type:misc/internal
potiuk
added
the
ready for maintainer review
SameerMesiah97
approved these changes
Jul 6, 2026
SameerMesiah97
left a comment
SameerMesiah97
left a comment
Contributor
There was a problem hiding this comment.
Looks good. It looks like you have replaced all repeated blocks of code in this file with an invocation to _build_latest_run_load_options. I do question the value of this refactor as duplicated block is fairly small, and having the loaded columns visible at each query makes the intent a bit more explicit. But I will not block the PR for such a subjective concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related : https://github.com/apache/airflow/pull/66488/changes/BASE..846d67b3fa51e5395fa5600aeb50555ddbaa34eb#r3341564478
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.